table, trains after midnight #8334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8334 +/- ##
============================================
+ Coverage 36.98% 37.05% +0.06%
Complexity 2211 2211
============================================
Files 1259 1260 +1
Lines 114565 114820 +255
Branches 3192 3223 +31
============================================
+ Hits 42374 42546 +172
- Misses 70290 70342 +52
- Partials 1901 1932 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
4 times, most recently
from
7e2b8f5
to
7354ddf
Compare
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
6 times, most recently
from
302df29
to
74edc28
Compare
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
74edc28
to
244baf6
Compare
theocrsb
reviewed
Aug 14, 2024
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
front/src/applications/operationalStudies/hooks/useSetupItineraryForTrainUpdate.ts
Outdated
Show resolved
Hide resolved
When I try to add 1 hour to 23 hours the requested departure time is not displayed. It is displayed when it is not midnight.
|
I don't know if this use case should be possible, but when I try to start the train 2 days later (172800 seconds), the requested departure time only shows J+1.
|
theocrsb
previously requested changes
Aug 14, 2024
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
3 times, most recently
from
0fa1f84
to
4fef754
Compare
It’s not a case we currently choose to handle |
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
c2ef063
to
b589d6a
Compare
anisometropie
requested review from
SharglutDev
and removed request for
clarani
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
b589d6a
to
0fadec5
Compare
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
2095f60
to
dd6cf07
Compare
They are meant to define clearly what they are, and give move details when you hover your mouse over them. I don’t want to lose the info and go back to a |
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
7 times, most recently
from
4ec2add
to
e028bc7
Compare
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
e028bc7
to
3355564
Compare
SharglutDev
approved these changes
Sep 17, 2024
anisometropie
dismissed
theocrsb’s stale review
on vacation, all the changes done !
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
2 times, most recently
from
fba5654
to
5a2c9e0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Signed-off-by: Valentin Chanas <[email protected]>
No change in behavior, just testing the previous behavior of the simulation input table, when a value changes. Signed-off-by: Valentin Chanas <[email protected]>
- using lodash pick to simplify the object construction - no need to lookup twice to find the corresponding pathStep - we don’t need to create copies of the pathSteps array since we are using immer to handle immutability for us - extracting the reducer logic in buildPathStepFromSuggestedOp to be reused Signed-off-by: Valentin Chanas <[email protected]>
Signed-off-by: Valentin Chanas <[email protected]>
anisometropie
force-pushed
the
vcs/trains-over-midnight
branch
from
5a2c9e0
to
143da9a
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7781
We now use a different format to represent
arrivalanddepartureinSuggestedOPandPathStep, an ISO duration string. The previous time string format hh:mm:ss was insufficient for distinguishing times spanning more than 24 hoursThese two types are used in different places beyond the scope of just the input/outpt, we should test everything that uses these two types