-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: split the ScenarioView into 2 components #8866
Conversation
- create a new ScenarioContent component which is rendered only if a scenario, a timetable and an infra exist - modify useScenarioData so scenario, timetable and infra are arguments of the hook
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8866 +/- ##
============================================
- Coverage 37.02% 36.93% -0.09%
Complexity 2211 2211
============================================
Files 1255 1258 +3
Lines 114227 114476 +249
Branches 3182 3184 +2
============================================
- Hits 42294 42285 -9
- Misses 70042 70298 +256
- Partials 1891 1893 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🚀 Amazing PR! Thanks for the great work! 🙌 |
Thanks for your review @achrafmohye, I think every thing is already memoized with useMemo or useCallback in useScenarioData, do you think I can do something else ? |
I added some memoization (for removeTrains and toggleMicroMacroButton) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work thank you.
Tested
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested, thanks for the great work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm nice work ! Much cleaner like this :)
closes #8867
See commits