Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added option for systemd-timesyncd #21

Merged
merged 12 commits into from
Feb 17, 2024
Merged

Conversation

builderjer
Copy link
Member

@builderjer builderjer requested a review from JarbasAl November 1, 2023 13:51
@JarbasAl
Copy link
Member

JarbasAl commented Nov 8, 2023

can we add a use_sudo flag for all those commands? this works if sudo is passwordless, would be set in mycroft.conf

@builderjer
Copy link
Member Author

can we add a use_sudo flag for all those commands? this works if sudo is passwordless, would be set in mycroft.conf

Not sure what you mean here. Where would this be added?

@j1nx
Copy link
Member

j1nx commented Jan 26, 2024

Gentle bump.

is this one still valid? Will see if i can implement this PR for testing for the buildroot image.

@builderjer
Copy link
Member Author

I think there's a typo somewhere, but use it works afik

@builderjer
Copy link
Member Author

@j1nx can you look again. It is loading well now

@JarbasAl JarbasAl changed the title added option for systemd-timesyncd feat: added option for systemd-timesyncd Feb 16, 2024
@JarbasAl JarbasAl added the enhancement New feature or request label Feb 16, 2024
@JarbasAl JarbasAl merged commit 6ca2157 into OpenVoiceOS:dev Feb 17, 2024
@j1nx
Copy link
Member

j1nx commented Feb 19, 2024

@j1nx can you look again. It is loading well now

As all PR's have been merged related to this, the code will be present in the nightly alpha containers so will have a look next time I boot a new build.

Thanks for this as it was one of my PHAL issues to resolve.

@neatbasis
Copy link

@j1nx can you look again. It is loading well now

As all PR's have been merged related to this, the code will be present in the nightly alpha containers so will have a look next time I boot a new build.

Thanks for this as it was one of my PHAL issues to resolve.

Are you sure it's not broken without my PR?

@j1nx
Copy link
Member

j1nx commented Feb 19, 2024

Are you sure it's not broken without my PR?

Haven't tested it as of yet. Will have a look later but guess by te time I get to it your PR is also merged, so all will be good.

@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants