Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for systemd-timesyncd #200

Merged
merged 2 commits into from
Feb 18, 2024
Merged

Option for systemd-timesyncd #200

merged 2 commits into from
Feb 18, 2024

Conversation

builderjer
Copy link
Member

@builderjer builderjer commented Oct 30, 2023 •
edited
Loading

requires PR from ovos-PHAL-plugin-system
OpenVoiceOS/ovos-PHAL-plugin-system#21

@builderjer builderjer mentioned this pull request Oct 30, 2023
Merged
@codecov
Copy link

codecov bot commented Oct 30, 2023 •
edited
Loading

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (773ad88) 42.53% compared to head (d4c972f) 42.67%.
Report is 2 commits behind head on dev.

❗ Current head d4c972f differs from pull request most recent head b96e418. Consider uploading reports for the commit b96e418 to get more accurate results

Files Patch % Lines
ovos_utils/system.py 61.53% 10 Missing ⚠️
ovos_utils/version.py 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #200      +/-   ##
==========================================
+ Coverage   42.53%   42.67%   +0.14%     
==========================================
  Files          31       31              
  Lines        3035     3060      +25     
==========================================
+ Hits         1291     1306      +15     
- Misses       1744     1754      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@builderjer builderjer mentioned this pull request Oct 30, 2023
Closed
NeonDaniel
NeonDaniel requested changes Oct 30, 2023
View reviewed changes
ovos_utils/system.py Outdated Show resolved Hide resolved
ovos_utils/system.py Outdated Show resolved Hide resolved
@JarbasAl
Copy link
Member

can we instead do this in the PHAL plugin and start removing these from ovos-utils?

keep ovos utils about ovos, let this stuff live in the respective plugins

@builderjer builderjer requested a review from NeonDaniel November 1, 2023 13:51
@builderjer
Copy link
Member Author

I deprecated all of the methods that I felt should go into the ovos-PHAL-plugin-system and made it an Admin Plugin

JarbasAl
JarbasAl reviewed Nov 8, 2023
View reviewed changes
ovos_utils/system.py Outdated Show resolved Hide resolved
@j1nx
Copy link
Member

j1nx commented Jan 27, 2024

Can someone help me with rebasing this?

am in process of getting the PHAL services into shape. The old ntpd not found bug is one of the issues to resolve.

@builderjer
Copy link
Member Author

I remember now. There is no self.bus so all of that needed swapped out. I will work on this this weekend

@j1nx j1nx mentioned this pull request Jan 27, 2024
Open
@builderjer @JarbasAl
rebased
6cacb4f 
removed deprecated failing tests
bump deprecation version to 0.2.0

fixed failing tests?

Update unit_tests.yml

removed python 3.7 from tests

finished fixing deprecation

fixed deprecated functions
@JarbasAl JarbasAl merged commit 59a7b4a into OpenVoiceOS:dev Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JarbasAl JarbasAl JarbasAl approved these changes

@NeonDaniel NeonDaniel Awaiting requested review from NeonDaniel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@builderjer @JarbasAl @j1nx @NeonDaniel