-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Screenshot and input update, requires C++17 #58
base: master
Are you sure you want to change the base?
Conversation
@Panzerschrek As requested the changes as separate commits of the previous PR |
@jopadan , i requested separate PRs, not separate commits within one PR. |
12819f6
to
58317ff
Compare
Separate review is possible at the Files Changed Tab. |
@jopadan , separate review means merging separate changes separately. I will try to review this, but it will take much longer time compared to approach with several separate PRs. |
CURSED/ | ||
CURSED/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a very good idea to list here all possible add-ons directories. Imagine doing this for Doom or Quake with thousands of add-ons.
Let's leave only directories, related to the original game.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the three common main addons to ignore is required for undisturbed in source tree development
#### Available add-ons: | ||
|
||
* Chasm - The Shadow Zone: ADDON1 | ||
* Chasm - Cursed Land : cursed | ||
* Chasm - Grim Borough : borough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to list here all available add-ons?
src/common/files.cpp
Outdated
|
||
} // namespace ChasmReverse | ||
|
||
std::filesystem::path remove_extension( const std::filesystem::path& path ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately std::filesystem
is not available in libc++ under Ubuntu 18.04. But we must support this system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d73ca2a
to
a42b1c0
Compare
84e5001
to
e4ea1ae
Compare
1f427c1
to
65db148
Compare
d749262
to
aac9937
Compare
4bfefe1
to
d0dfd5e
Compare
* SystemEvents in KeyChecker * ControlMenu now looks like ChasmPortable * add remappable keys present in original portable release like center_view and weapon_next/prev * SavesComment now contains time instead of LevelHealth * TGAWrite modification for screenshots * use strcasestr and strcasecmp * switch from KeyboardState to InputState allowing other input device type states * use char32_t instead of unsigned int for KeyCode * allow mouse control remap * allow rotate/wrap for msaa and pixel_size * fix character input in window resolution video menu * modify WriteTGA to support RGBA32 flipped input if palette equals nullptr * add SystemEvent support to KeyChecker * add screenshot implementation * use timestamp for saves instead of Level and Health * add LICENSE * add add-on list in README.md * add physfs and cgltf as submodule in external * support loading new TAR format csm.bin with PhysicsFS
3rd party references & credits
TODO