Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot and input update, requires C++17 #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jopadan
Copy link

@jopadan jopadan commented Jun 3, 2023

  • SystemEvents in KeyChecker
  • ControlMenu now looks like ChasmPortable
  • add remappable keys present in original portable release like center_view and weapon_next/prev
  • SavesComment now contains time instead of LevelHealth
  • TGAWrite modification for screenshots
  • use strcasestr and strcasecmp
  • switch from KeyboardState to InputState allowing other input device type states
  • use char32_t instead of unsigned int for KeyCode
  • allow mouse control remap
  • allow rotate/wrap for msaa and pixel_size
  • fix character input in window resolution video menu
  • modify WriteTGA to support RGBA32 flipped input if palette equals nullptr
  • add SystemEvent support to KeyChecker
  • add screenshot implementation
  • use timestamp for saves instead of Level and Health
  • add LICENSE
  • add add-on list in README.md
  • support loading new TAR format csm.bin with PhysFS

3rd party references & credits

TODO

@jopadan
Copy link
Author

jopadan commented Jun 4, 2023

@Panzerschrek As requested the changes as separate commits of the previous PR

@Panzerschrek
Copy link
Owner

@jopadan , i requested separate PRs, not separate commits within one PR.
Separate PRs are required in order to review/merge separate changes separately. With one PR (even with changes splitted per-commit) it is impossible.

@jopadan
Copy link
Author

jopadan commented Jul 17, 2023

Separate review is possible at the Files Changed Tab.
Opening multiple PRs requires creating separate branches and cherry-picking all the commits which is a too time consuming task.

@Panzerschrek
Copy link
Owner

@jopadan , separate review means merging separate changes separately.
Such huge PR can not be merged until all issues will be fixed.

I will try to review this, but it will take much longer time compared to approach with several separate PRs.

Comment on lines +26 to +53
CURSED/
CURSED/*
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a very good idea to list here all possible add-ons directories. Imagine doing this for Doom or Quake with thousands of add-ons.
Let's leave only directories, related to the original game.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the three common main addons to ignore is required for undisturbed in source tree development

Comment on lines +59 to +68
#### Available add-ons:

* Chasm - The Shadow Zone: ADDON1
* Chasm - Cursed Land : cursed
* Chasm - Grim Borough : borough
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to list here all available add-ons?

src/client/client.cpp Outdated Show resolved Hide resolved

} // namespace ChasmReverse

std::filesystem::path remove_extension( const std::filesystem::path& path )
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately std::filesystem is not available in libc++ under Ubuntu 18.04. But we must support this system.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably the same topic as #61
Maybe askubuntu might help you.

src/common/files.hpp Outdated Show resolved Hide resolved
src/save_load.cpp Outdated Show resolved Hide resolved
src/save_load.cpp Outdated Show resolved Hide resolved
src/system_window.cpp Outdated Show resolved Hide resolved
src/system_window.cpp Outdated Show resolved Hide resolved
src/system_window.cpp Outdated Show resolved Hide resolved
@jopadan jopadan force-pushed the master branch 5 times, most recently from d73ca2a to a42b1c0 Compare July 19, 2023 16:00
@jopadan jopadan changed the title Screenshots, remappable and mouse menu input Screenshot and input update, requires C++17 Jul 19, 2023
@jopadan jopadan force-pushed the master branch 2 times, most recently from 84e5001 to e4ea1ae Compare July 21, 2023 17:29
@jopadan jopadan force-pushed the master branch 2 times, most recently from 1f427c1 to 65db148 Compare August 3, 2023 19:02
@jopadan jopadan force-pushed the master branch 4 times, most recently from d749262 to aac9937 Compare November 27, 2023 18:01
@jopadan jopadan force-pushed the master branch 3 times, most recently from 4bfefe1 to d0dfd5e Compare August 12, 2024 23:00
Jon Daniel and others added 2 commits August 13, 2024 04:14
* SystemEvents in KeyChecker
* ControlMenu now looks like ChasmPortable
* add remappable keys present in original portable release like center_view and weapon_next/prev
* SavesComment now contains time instead of LevelHealth
* TGAWrite modification for screenshots
* use strcasestr and strcasecmp
* switch from KeyboardState to InputState allowing other input device type states
* use char32_t instead of unsigned int for KeyCode
* allow mouse control remap
* allow rotate/wrap for msaa and pixel_size
* fix character input in window resolution video menu
* modify WriteTGA to support RGBA32 flipped input if palette equals nullptr
* add SystemEvent support to KeyChecker
* add screenshot implementation
* use timestamp for saves instead of Level and Health
* add LICENSE
* add add-on list in README.md
* add physfs and cgltf as submodule in external
* support loading new TAR format csm.bin with PhysicsFS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants