When core installers are disabled nothing should run

Rename the test Remove redundant line
Particular · Nov 20, 2020 · 128dfbc · 128dfbc
1 parent d60e246
commit 128dfbc
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/NServiceBus.Persistence.AzureTable/Subscriptions/SubscriptionStorageInstallerFeature.cs b/src/NServiceBus.Persistence.AzureTable/Subscriptions/SubscriptionStorageInstallerFeature.cs
@@ -13,6 +13,13 @@ public SubscriptionStorageInstallerFeature()
         protected override void Setup(FeatureConfigurationContext context)
         {
             var settings = context.Settings.Get<SubscriptionStorageInstallerSettings>();
+
+            // if it hasn't been explicitly disabled installer settings need to be considered
+            if (!settings.Disabled)
+            {
+                settings.Disabled = !context.Settings.GetOrDefault<bool>("Installers.Enable");
+            }
+
             if (settings.Disabled)
             {
                 return;

diff --git a/...viceBus.Persistence.AzureTable/SynchronizedStorage/SynchronizedStorageInstallerFeature.cs b/...viceBus.Persistence.AzureTable/SynchronizedStorage/SynchronizedStorageInstallerFeature.cs
@@ -13,6 +13,12 @@ protected override void Setup(FeatureConfigurationContext context)
         {
             var settings = context.Settings.Get<SynchronizedStorageInstallerSettings>();
 
+            // if it hasn't been explicitly disabled installer settings need to be considered
+            if (!settings.Disabled)
+            {
+                settings.Disabled = !context.Settings.GetOrDefault<bool>("Installers.Enable");
+            }
+
             if (settings.Disabled)
             {
                 return;

diff --git a/...e_doesnt_exist_and_schema_creation_off.cs → ...esnt_exist_and_table_creation_disabled.cs b/...e_doesnt_exist_and_schema_creation_off.cs → ...esnt_exist_and_table_creation_disabled.cs
@@ -10,7 +10,7 @@ namespace NServiceBus.AcceptanceTests
     using EndpointTemplates;
     using NUnit.Framework;
 
-    public partial class When_saga_table_doesnt_exist_and_schema_creation_off : NServiceBusAcceptanceTest
+    public partial class When_saga_table_doesnt_exist_and_table_creation_disabled : NServiceBusAcceptanceTest
     {
         [Test]
         public void Should_throw_not_supported()