This repository has been archived by the owner on Aug 17, 2024. It is now read-only.
replaced split_line with a multibyte aware version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
split_line was working fine as long as the input was just plain US-ASCII. When using multibyte characters and they happened to be at the end of the line to spit the function did panic. The new code returns correctly split lines even if they contain multibyte characters.
|
related to #60 |
|
Hello @ronnybremer, thanks for the PR. I will take a look asap |
Done. I also fixed the broken test from before, needed to take 75 characters of the first line but only 74 characters of subsequent lines as a " " is added in front of each line. |
the text to test should include the expected newline characters
|
I had to fix the test, too bad I can't run it myself without checking out the repo. The |
|
@Peltoche would you please start the testing stage again? Thank you. |
|
one last wrong character, can't believe it :( |
|
Sorry for the delay. |
|
LGTM, thanks for this PR 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
split_line was working fine as long as the input was just plain US-ASCII. When using multibyte characters and they happened to be at the end of the line to spit the function did panic.
The new code returns correctly split lines even if they contain multibyte characters.