Skip to content
This repository has been archived by the owner on Aug 17, 2024. It is now read-only.

replaced split_line with a multibyte aware version #61

Merged
merged 5 commits into from
Mar 1, 2024
Merged

replaced split_line with a multibyte aware version #61

merged 5 commits into from
Mar 1, 2024

Commits on Jan 27, 2024

  1. replaced split_line with a multibyte aware version 

    split_line was working fine as long as the input was just plain US-ASCII. When using multibyte characters and they happened to be at the end of the line to spit the function did panic.

The new code returns correctly split lines even if they contain multibyte characters.
    @ronnybremer
    ronnybremer committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    a92678d View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2024

  1. take 75 chars of the first line and 74 chars of subsequent lines 

    the existing test failed
    @ronnybremer
    ronnybremer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    1518ca0 View commit details
    Browse the repository at this point in the history

  2. added test case with multibyte characters for split_line

    @ronnybremer
    ronnybremer committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    44b9757 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. fixed incorrect test for new split_line 

    the text to test should include the expected newline characters
    @ronnybremer
    ronnybremer committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b5027f3 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. final fix to test for new split_line

    @ronnybremer
    ronnybremer committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    e66b13c View commit details
    Browse the repository at this point in the history