Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make M0 TR optional for BASIL #323

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Make M0 TR optional for BASIL #323

merged 2 commits into from
Sep 20, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 20, 2023 •
edited
Loading

Closes #322.

Changes proposed in this pull request

  • Use the control volumes' TR for BASIL's M0 TR if M0Type is "absent".
  • Do not set an M0 TR for BASIL if M0Type is "estimate".

@tsalo tsalo added the bug Something isn't working label Sep 20, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage is 25.00% of modified lines.

Files Changed Coverage
aslprep/interfaces/cbf.py 0.00%
aslprep/workflows/asl/cbf.py 50.00%

📢 Thoughts on this report? Let us know!.

@tsalo
Copy link
Member Author

tsalo commented Sep 20, 2023

I'm going to push this through, since it seems to fix things for NKI.

@tsalo tsalo merged commit c0fa24e into PennLINC:main Sep 20, 2023
2 checks passed
@tsalo tsalo deleted the fix-basil branch December 12, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support --basil with absent or estimate M0 scans
2 participants
@tsalo @codecov-commenter