Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling data dramatically affects ALFF #1032

Open
tsalo opened this issue Jan 12, 2024 · 2 comments
Open

Scaling data dramatically affects ALFF #1032

tsalo opened this issue Jan 12, 2024 · 2 comments
Assignees
Labels
bug Issues noting problems and PRs fixing those problems.

Comments

@tsalo
Copy link
Member

tsalo commented Jan 12, 2024

Summary

Just to be clear, this documents a problem with the ALFF metric, not with XCP-D.

ALFF is dependent on the scale of the data, so the scaling step I added in #1020 dramatically changes the ALFF outputs. Unfortunately, it's not just a change in the ALFF scale, since some testing by @joellebagautdinova shows that the ALFF maps produced from scaled data don't show any of the spatial patterns that ALFF maps produced from unscaled data do.

The spatial patterns in the unscaled (i.e., original) ALFF maps are very similar to the mean BOLD maps from the preprocessed data (and probably the intercept image from the denoising step), so ALFF itself may be problematic, but it's also clear that the scaled ALFF looks bad.

Additional details

  • xcp_d version: 0.6.1 (unreleased)
  • Docker version:
  • Singularity version:
@tsalo tsalo added the bug Issues noting problems and PRs fixing those problems. label Jan 12, 2024
@tsalo tsalo self-assigned this Jan 16, 2024
@tsalo
Copy link
Member Author

tsalo commented Jan 17, 2024

The scaling difference is handled by #1033, but my concerns about ALFF remain unresolved.

@tsalo
Copy link
Member Author

tsalo commented Apr 16, 2024

Should we do what other ALFF implementations have done and scale by the mean ALFF value in the brain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues noting problems and PRs fixing those problems.
Projects
None yet
Development

No branches or pull requests

1 participant