Rescale ALFF based on original BOLD standard deviation #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsalo
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
==========================================
+ Coverage 82.25% 82.27% +0.01%
==========================================
Files 48 48
Lines 5776 5782 +6
Branches 767 767
==========================================
+ Hits 4751 4757 +6
Misses 829 829
Partials 196 196 ☔ View full report in Codecov by Sentry. |
mattcieslak
approved these changes
Jan 16, 2024
| @@ -178,6 +184,8 @@ def compute_alff(data_matrix, low_pass, high_pass, TR, sample_mask=None): | |||
| # from the value closest to the low pass cutoff, to the value closest | |||
| # to the high pass pass cutoff | |||
| alff[i_voxel] = len(ff_alff) * np.mean(power_spectrum_sqrt[ff_alff[0] : ff_alff[1]]) | |||
| # Rescale ALFF based on original BOLD scale | |||
| alff[i_voxel] *= sd_scale | |||
There was a problem hiding this comment.
ohh so both periodogram and lombscargle get the scaling and rescaling?
There was a problem hiding this comment.
Yes, though it's probably unnecessary for the periodogram version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1032.
Changes proposed in this pull request