-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace restricted confound sets with config files #1255
Open
tsalo
wants to merge
53
commits into
PennLINC:main
Choose a base branch
from
tsalo:custom-playground
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm going to put the filtered motion parameters in the same file as the unfiltered ones, with `_filtered` appended to the column names.
tsalo
changed the title
Custom playground
Replace restricted confound sets with config files
Sep 17, 2024
tsalo
added
enhancement
New feature or request
breaking-change
PRs that change results or interfaces.
labels
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1252 and closes #1231.
Changes proposed in this pull request
--derivatives
argument that accepts paths to derivatives datasets.--derivatives
keyword argument) is internally referred to as "preprocessing".--derivatives aroma=/path/to/fmripost-aroma
.--custom-confounds
argument. This is a breaking change.