Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xcp_d_dir and clean datasinks #1262

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 13, 2024

Closes none.

Changes proposed in this pull request

  • Drop config.execution.xcp_d_dir in favor of the existing config.execution.output_dir.
  • Rename any figure-generating datasinks to start with ds_report_ and drop datatype="figures".
  • Loop over nodes and automatically set datatype to "figures" for nodes starting with ds_report_.
  • Loop over nodes and automatically set base_directory to config.execution.output_dir for nodes starting with ds_.

@tsalo tsalo added the refactor Changes to the codebase that don't impact workflow inputs or outputs. label Sep 13, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.40%. Comparing base (4fd16f1) to head (a232926).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   78.47%   78.40%   -0.07%     
==========================================
  Files          59       59              
  Lines        7218     7204      -14     
  Branches     1064     1064              
==========================================
- Hits         5664     5648      -16     
- Misses       1284     1286       +2     
  Partials      270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 0c1e0bb into PennLINC:main Sep 17, 2024
20 of 21 checks passed
@tsalo tsalo deleted the clean-datasinks branch September 17, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant