Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dataset links to config object #1266

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 17, 2024

Closes none.

Changes proposed in this pull request

  • Rename write_dataset_description function to write_derivative_description.
  • Add dataset_links to config object.
  • Write out DatasetLinks to dataset_description.json.

@tsalo tsalo added enhancement New feature or request refactor Changes to the codebase that don't impact workflow inputs or outputs. and removed enhancement New feature or request labels Sep 17, 2024
@tsalo tsalo marked this pull request as ready for review September 17, 2024 20:03
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (a8c402b) to head (7af7ebd).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1266      +/-   ##
==========================================
+ Coverage   78.40%   78.41%   +0.01%     
==========================================
  Files          59       59              
  Lines        7204     7210       +6     
  Branches     1064     1065       +1     
==========================================
+ Hits         5648     5654       +6     
  Misses       1286     1286              
  Partials      270      270              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo changed the title Add DatasetLinks to dataset_description.json Add DatasetLinks to config object Sep 17, 2024
@tsalo tsalo changed the title Add DatasetLinks to config object Add dataset links to config object Sep 17, 2024
@tsalo tsalo merged commit 37dd906 into PennLINC:main Sep 17, 2024
21 checks passed
@tsalo tsalo deleted the rename-function branch September 17, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Changes to the codebase that don't impact workflow inputs or outputs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant