Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename --derivatives parameter to --datasets #1276

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 2, 2024

Closes none. Splits out a backward-incompatible change from #1265.

Changes proposed in this pull request

  • Rename the --derivatives parameter to --datasets, to prepare to allow BIDS-Atlas datasets.
  • Change xcp-d to XCP-D throughout the package.

@tsalo tsalo added the breaking-change PRs that change results or interfaces. label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (b160183) to head (06d049b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
xcp_d/cli/combineqc.py 0.00% 1 Missing ⚠️
xcp_d/utils/bids.py 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1276      +/-   ##
==========================================
- Coverage   78.56%   78.55%   -0.01%     
==========================================
  Files          59       59              
  Lines        7309     7312       +3     
  Branches     1104     1105       +1     
==========================================
+ Hits         5742     5744       +2     
  Misses       1279     1279              
- Partials      288      289       +1     
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit b766391 into PennLINC:main Oct 2, 2024
22 checks passed
@tsalo tsalo deleted the derivatives-to-datasets branch October 2, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change PRs that change results or interfaces.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant