Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split HCP tasks into task and run entities #952

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Oct 2, 2023

Closes #951.

Changes proposed in this pull request

  • Use a regular expression to split the HCP task name into a task entity and a run entity.
    • For example, REST1 becomes task-rest_run-1.

@tsalo tsalo added the enhancement New feature or request label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Files Coverage Δ
xcp_d/utils/hcp2fmriprep.py 10.07% <16.66%> (+0.40%) ⬆️

📢 Thoughts on this report? Let us know!.

@tsalo tsalo merged commit 273fa8c into PennLINC:main Oct 4, 2023
17 of 19 checks passed
@tsalo tsalo deleted the hcp-task-names branch October 4, 2023 19:13
@tsalo tsalo restored the hcp-task-names branch October 9, 2023 20:27
tsalo added a commit to tsalo/xcp_d that referenced this pull request Oct 9, 2023
@tsalo tsalo deleted the hcp-task-names branch November 2, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split HCP task name and run number as part of ingression
1 participant