Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INF-8817 Allow filtering Docker registries by regex #14

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

LucaHennart
Copy link

@LucaHennart LucaHennart commented Dec 20, 2024

Commit message:

INF-8817 Allow filtering Docker registries by regex

Note: This option is not documented , but it does exist 🤷🏻

Copy link
Member

@CCardosoDev CCardosoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the target branch fork/v2.2.12?

@@ -146,6 +146,7 @@ dockerRegistries:
- name: dockerhub
address: index.docker.io
noValidate: false
repositoriesRegex: '^filtered-repository$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will the value for filtered-repository be set?

Copy link
Author

@LucaHennart LucaHennart Dec 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right here.

In Dev, we will allow a few images for testing purposes. In Prod, we will allow teampicnic/** images, effectively ignoring pull through cache images.

@LucaHennart
Copy link
Author

@CCardosoDev fork/v2.2.12 is the branch for where Picnic started to add patches (now 14 patches), some 3y ago.

@LucaHennart LucaHennart removed the request for review from Badbond December 31, 2024 12:51
Copy link

@nathankooij nathankooij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was only thinking if we should change the default value but I see that the other default values also need to be overridden anyway to make sense so let’s roll with it. 👍

@LucaHennart
Copy link
Author

Was only thinking if we should change the default value

Yeah, I kept it very generic to align with the values.yaml defaults, which come from the OSS chart and have nothing to do with our usage at Picnic. 👍🏻

@LucaHennart LucaHennart merged commit 8435cbb into fork/v2.2.12 Jan 2, 2025
@LucaHennart LucaHennart deleted the lhennart/INF-8817 branch January 2, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants