-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INF-8817 Allow filtering Docker registries by regex #14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the target branch fork/v2.2.12
?
@@ -146,6 +146,7 @@ dockerRegistries: | |||
- name: dockerhub | |||
address: index.docker.io | |||
noValidate: false | |||
repositoriesRegex: '^filtered-repository$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where will the value for filtered-repository
be set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right here.
In Dev, we will allow a few images for testing purposes. In Prod, we will allow teampicnic/**
images, effectively ignoring pull through cache images.
@CCardosoDev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was only thinking if we should change the default value but I see that the other default values also need to be overridden anyway to make sense so let’s roll with it. 👍
Yeah, I kept it very generic to align with the values.yaml defaults, which come from the OSS chart and have nothing to do with our usage at Picnic. 👍🏻 |
Commit message: