Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INF-8817 Allow filtering Docker registries by regex #14

Merged
merged 2 commits into from
Jan 2, 2025
Merged

INF-8817 Allow filtering Docker registries by regex #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1571551
INF-8817 Wire --repositories-regex option for Hayard's DockerRegistry…
LucaHennart Dec 20, 2024
150033f
INF-8817 Bump
LucaHennart Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/spinnaker/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v1
description: Open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.
name: spinnaker
version: 2.2.12-picnic-13
version: 2.2.12-picnic-14
appVersion: 1.26.6
home: http://spinnaker.io/
sources:
Expand Down
1 change: 1 addition & 0 deletions charts/spinnaker/templates/configmap/halyard-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ data:
{{ if $registry.passwordCommand -}} --password-command "{{ $registry.passwordCommand }}"{{ else -}} --password-file /opt/registry/passwords/{{ $registry.name }}{{- end }} \
{{ if $registry.email -}} --email {{ $registry.email }}{{- end -}}{{- end }} \
{{ if $registry.noValidate -}} --no-validate {{- end }} \
{{ if $registry.repositoriesRegex -}} --repositories-regex '{{ $registry.repositoriesRegex }}' {{- end }} \
{{ if $registry.repositories -}} --repositories {{ range $index, $repository := $registry.repositories }}{{if $index}},{{end}}{{- $repository }}{{- end }}{{- end }}

{{- end }}
Expand Down
1 change: 1 addition & 0 deletions charts/spinnaker/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,7 @@ dockerRegistries:
- name: dockerhub
address: index.docker.io
noValidate: false
repositoriesRegex: '^filtered-repository$'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where will the value for filtered-repository be set?

Copy link
Author

@LucaHennart LucaHennart Dec 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right here.

In Dev, we will allow a few images for testing purposes. In Prod, we will allow teampicnic/** images, effectively ignoring pull through cache images.

repositories:
- library/alpine
- library/ubuntu
Expand Down