fix: full snapshot every 10 minutes #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +84 B (0%) Total Size: 725 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Oct 23, 2023
src/extensions/sessionrecording.ts
Outdated
| @@ -22,6 +22,7 @@ import { logger, loadScript, _timestamp, window } from '../utils' | |||
| const BASE_ENDPOINT = '/s/' | |||
|
|
|||
| export const RECORDING_IDLE_ACTIVITY_TIMEOUT_MS = 5 * 60 * 1000 // 5 minutes | |||
| export const THIRTY_MINUTES_IN_MS = 30 * 60 * 1000 | |||
There was a problem hiding this comment.
This makes total sense... I even wonder if we shouldn't make it slightly lower, like say 10 mins?
pauldambra
changed the title
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't configure regular checkouts on recordings. That is a common perf improvement for "long recordings"
Let's try auto checkout every 30 minutes.
Tested by setting a lower value and seeing full snapshots at expected interval (and checking I could play back the recordings)