feat: retry count in url #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
Size Change: +1.01 kB (0%) Total Size: 712 kB
|
pauldambra
commented
Oct 27, 2023
pauldambra
commented
Oct 27, 2023
| @@ -29,7 +32,7 @@ export const addParamsToURL = ( | |||
|
|
|||
| export const encodePostData = (data: PostData | Uint8Array, options: Partial<XHROptions>): string | BlobPart | null => { | |||
| if (options.blob && data.buffer) { | |||
| return new Blob([data.buffer], { type: 'text/plain' }) | |||
| return new Blob([_isUint8Array(data) ? data : data.buffer], { type: 'text/plain' }) | |||
There was a problem hiding this comment.
our JS tests were using snapshots here. And the snapshot was happily passing when this method returned the empty array for Uint8Arrays passed in
|
@daibhin @benjackwhite it's best to go through this one a commit at a time with hide whitespace on 🙈 |
the moving around of things is partly because we have a big chunk of the bundle in |
daibhin
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an incident we are sometimes flooded with retries from the JS SDK.
Or at least we believe we are. And, when we are we don't know how many retries there are.
Let's add the retry count to the URL so we can figure things out by inspecting the capture logs
Tested locally that I can still ingest events etc