feat: don't report on file size of files we can infer from the main files #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 487 kB ℹ️ View Unchanged
|
neilkakkar
reviewed
Oct 29, 2023
.github/workflows/bundled-size.yaml
Outdated
| @@ -12,3 +12,7 @@ jobs: | |||
| with: | |||
| build-script: "build-rollup" | |||
| compression: "none" | |||
| # no need to report on files that aren't the interesting ones | |||
| exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,**/*.map,**/node_modules/**}" | |||
There was a problem hiding this comment.
I want one module file atleast please, very useful for PRs like these: #863
There was a problem hiding this comment.
(and keeps the module file size in check as well, not just the snippet)
| # no need to report on files that aren't the interesting ones | ||
| exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,**/*.map,**/node_modules/**}" | ||
| # no need to report on very small byte changes which show as 0% change | ||
| minimum-change-threshold: 300 |
There was a problem hiding this comment.
a secondary benefit of this reporting is ensuring all changes you're doing are bundled correctly, not just when size bloats up too much, so I'd like to not have this minimum threshold.
"I updated module types, but oh, the module size didn't change - what's going wrong?" oh, gotta export it too 🤷
There was a problem hiding this comment.
#til 👍
I've never once looked at them 🙉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use automation to track bundle size but it reports on every file in the dist folder. We only care about some of the files.
The GitHub action supports inclusion and exclusion lists: https://github.com/preactjs/compressed-size-action#customizing-the-list-of-files
Let's