Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: don't report on file size of files we can infer from the main files #865

Closed
wants to merge 5 commits into from
Closed

feat: don't report on file size of files we can infer from the main files #865

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ea79bc
feat: don't report on file size of files we can infer from the main f…
pauldambra Oct 29, 2023
1e63ec4
add minimum size threshold for reporting
pauldambra Oct 29, 2023
27a06ea
Update bundled-size.yaml
pauldambra Oct 29, 2023
a28b214
Update bundled-size.yaml
pauldambra Oct 29, 2023
b8a1a4f
Update bundled-size.yaml
pauldambra Oct 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/bundled-size.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ jobs:
with:
build-script: "build-rollup"
compression: "none"
# no need to report on files that aren't the interesting ones
exclude: "{./dist/es.js,./dist/module.js,./dist/array.full.js,**/*.map,**/node_modules/**}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want one module file atleast please, very useful for PRs like these: #863

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(and keeps the module file size in check as well, not just the snippet)

# no need to report on very small byte changes which show as 0% change
minimum-change-threshold: 300
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a secondary benefit of this reporting is ensuring all changes you're doing are bundled correctly, not just when size bloats up too much, so I'd like to not have this minimum threshold.

"I updated module types, but oh, the module size didn't change - what's going wrong?" oh, gotta export it too 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#til 👍

I've never once looked at them 🙉

Loading