fix(experiments): Hackily apply timestamp to ASOF LEFT JOIN #26852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timgl
requested changes
Dec 11, 2024
posthog/warehouse/models/join.py
Outdated
| # :HACK: We need to pull the timestamp gt/lt values from node.where.exprs[0] because | ||
| # we can't reference the parent data warehouse table in the where clause. | ||
| if ( | ||
| node.where.exprs[0].op == ast.CompareOperationOp.GtEq |
There was a problem hiding this comment.
WhereClauseExtractor is probably a better way of doing this.
|
@timgl I added a test to assert the contents of the
I'm not sure I follow. Can you provide a specific example? |
timgl
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://posthog.slack.com/archives/C07PXH2GTGV/p1733941329943129?thread_ts=1733936406.339719&cid=C07PXH2GTGV
See #26332
Changes
Hackily pulls timestamp statements from
node.whereand applies them to the ASOF LEFT JOIN.Ideally, we'd directly reference the timestamp column from the data warehouse table. However, HogQL doesn't support referencing the parent clause, so this will have to suffice for now.
Includes a test to assert that the clause is included in the generated ClickHouse SQL.
How did you test this code?
Tests should pass. I also inspected the query output.