Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add a DynBlockRulesGroup:removeRange() binding #13342

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Oct 6, 2023

Short description

This adds the ability to remove an existing range from the list of existing included/excluded ranges.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@Habbie Habbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, one doc nit

pdns/dnsdistdist/docs/reference/config.rst Show resolved Hide resolved
@rgacogne rgacogne requested a review from Habbie October 19, 2023 13:03
This adds the ability to remove an existing range from the list of
existing included/excluded ranges.
@rgacogne
Copy link
Member Author

Rebased on master.

@coveralls
Copy link

coveralls commented Oct 19, 2023

Pull Request Test Coverage Report for Build 6575778053

  • 1 of 24 (4.17%) changed or added relevant lines in 3 files are covered.
  • 35 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-0.02%) to 57.468%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pdns/iputils.hh 0 5 0.0%
pdns/dnsdist-dynblocks.hh 0 6 0.0%
pdns/dnsdist-lua-inspection.cc 1 13 7.69%
Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 1 96.57%
pdns/dnsdist.cc 2 70.79%
pdns/tcpiohandler.cc 2 66.65%
pdns/recursordist/taskqueue.hh 3 71.43%
pdns/recursordist/rec-zonetocache.cc 4 50.1%
pdns/recursordist/rec-main.cc 8 35.11%
pdns/recursordist/rec-taskqueue.cc 15 30.8%
Totals Coverage Status
Change from base Build 6574953728: -0.02%
Covered Lines: 105349
Relevant Lines: 152672

💛 - Coveralls

@rgacogne rgacogne requested review from Habbie and removed request for Habbie October 31, 2023 07:35
@rgacogne rgacogne merged commit 2a54c59 into PowerDNS:master Nov 3, 2023
74 checks passed
@rgacogne rgacogne deleted the ddist-dbrg-remove-range branch November 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants