Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Give a more clear error message if the build fails because python was not found #14697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

omoerbeek
Copy link
Member

But don't report an error during configure:

When building from a src tarball you don't need python (the tarball includes the generated files), but that changes if settings/table.py was modified or when building from a github checkout.

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek omoerbeek added the rec label Sep 20, 2024
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Sep 20, 2024
@coveralls
Copy link

coveralls commented Sep 20, 2024

Pull Request Test Coverage Report for Build 10960690682

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 30 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.006%) to 64.702%

Files with Coverage Reduction New Missed Lines %
pdns/backends/gsql/gsqlbackend.hh 2 97.71%
modules/lmdbbackend/lmdbbackend.cc 2 72.54%
pdns/ws-auth.cc 2 80.8%
pdns/misc.cc 2 63.15%
pdns/dnsdistdist/dnsdist.cc 2 68.36%
pdns/iputils.cc 3 55.45%
pdns/packethandler.cc 3 72.56%
pdns/recursordist/pdns_recursor.cc 3 72.7%
pdns/signingpipe.cc 5 83.11%
pdns/recursordist/test-syncres_cc1.cc 6 89.59%
Totals Coverage Status
Change from base Build 10960020735: 0.006%
Covered Lines: 124833
Relevant Lines: 162222

💛 - Coveralls

@paddg
Copy link
Contributor

paddg commented Sep 20, 2024

In our case python2 was installed, but python3 was needed if I remember correctly.

@omoerbeek
Copy link
Member Author

In our case python2 was installed, but python3 was needed if I remember correctly.

Ah, I'll extend the test to include that case then

…n was not found

When building from a src tarball you don't need python (the tarball
includes the generated files), but that changes if settings/table.py was
modified or when building from a github checkout.
@paddg
Copy link
Contributor

paddg commented Sep 20, 2024

Ah, TIL "Python 4.0 will probably never come" :)

@omoerbeek
Copy link
Member Author

Ah, TIL "Python 4.0 will probably never come" :)

I plan to be retired by then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants