Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rec: Give a more clear error message if the build fails because python was not found #14697

Merged
merged 2 commits into from
Oct 7, 2024
Merged

rec: Give a more clear error message if the build fails because python was not found #14697

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
030f54a
rec: Give a more clear error message if the build fails because pytho…
omoerbeek Sep 20, 2024
bb3ae5f
Apply suggestions from code review
omoerbeek Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pdns/recursordist/settings/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ BUILT_SOURCES=cxxsettings-generated.cc rust/src/lib.rs
#
# Use patterns to avoid having two instances of generate run simultaneously, a well-known hack for GNU make
cxxsettings-generated%cc rust/src/lib%rs: table.py generate.py rust-preamble-in.rs rust-bridge-in.rs docs-old-preamble-in.rst docs-new-preamble-in.rst
@if test "$(PYTHON)" = ":"; then echo "Settings table table.py has changed, python is needed to regenerate the related settings files but python was not found. Please install python and re-run configure"; exit 1; fi
@if ! $(PYTHON) --version | grep -q "Python 3"; then echo $(PYTHON) should be at least version 3. Please install python 3 and re-run configure; exit 1; fi
$(MAKE) -C rust clean
(cd ${srcdir} && $(PYTHON) generate.py)

Expand Down
Loading