chore: cleanup workflows #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jamiezieziula
commented
Sep 27, 2023
jamiezieziula
commented
- Remove updatecli from managing workflows
- update codeowners
- remove stale issues workflow
jamiezieziula
commented
Sep 27, 2023
Comment on lines
-17
to
-28
| helm: | ||
| kind: githubRelease | ||
| spec: | ||
| owner: helm | ||
| repository: helm | ||
| token: '{{ requiredEnv "GITHUB_TOKEN" }}' | ||
| versionFilter: | ||
| kind: semver | ||
| pattern: "x.x.x" | ||
| transformers: | ||
| - trimprefix: "v" | ||
| kind: |
There was a problem hiding this comment.
these were managing the version of helm/kind to specify in the lint/test workflows. Since we were always updating to latest, removing this and just allowing the default version to apply.
jamiezieziula
commented
Sep 27, 2023
Comment on lines
-44
to
-45
| with: | ||
| version: v3.9.2 |
There was a problem hiding this comment.
this is the only thing im concerned about - should we just default to the latest (stable) helm version here?
There was a problem hiding this comment.
Yes I think latest helm3 version
jimid27
reviewed
Sep 27, 2023
| # │ │ │ │ │ | ||
| # │ │ │ │ │ | ||
| # │ │ │ │ │ | ||
| - cron: 0 15 1 * * # The first of each month at 10am EST |
There was a problem hiding this comment.
yaml doesn't get mad at unquoted here?
There was a problem hiding this comment.
nope! we use this pattern in other repos already
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.