chore: cleanup workflows #245
There are no files selected for viewing
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| * @PrefectHQ/platform |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| --- | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: github-actions | ||
| directory: / | ||
| schedule: | ||
| interval: weekly |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,14 @@ | ||
| name: Lint and Test Prefect Agent Chart | ||
|
|
||
| "on": | ||
| pull_request: | ||
| paths: | ||
| - .github/workflows/agent-lint-and-test.yaml | ||
| - .github/linters/agent-ct.yaml | ||
| - charts/prefect-agent/** | ||
|
|
||
| jobs: | ||
| lint_test: | ||
| name: "lint-test (${{ matrix.kubernetes }})" | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
|
|
@@ -16,25 +18,29 @@ jobs: | |
| - "1.26.3" | ||
| - "1.27.0" | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Helm | ||
| uses: azure/[email protected] | ||
|
|
||
| - name: Set up chart-testing | ||
| uses: helm/[email protected] | ||
|
|
||
| - name: Run chart-testing (lint) | ||
| run: ct lint --config .github/linters/agent-ct.yaml | ||
|
|
||
| - name: Create kind cluster | ||
| uses: helm/[email protected] | ||
| with: | ||
| node_image: "kindest/node:v${{ matrix.kubernetes }}" | ||
|
|
||
| - name: Create API Secret for Agent Chart | ||
| run: | | ||
| kubectl create ns prefect | ||
| kubectl create secret generic prefect-api-key --from-literal=key=${{ secrets.PREFECT_CLOUD_API_KEY }} -n prefect | ||
|
|
||
| - name: Run chart-testing (install) | ||
| run: ct install --config .github/linters/agent-ct.yaml --helm-extra-set-args "--set=agent.config.workQueueName=test-helm --set=agent.cloudApiConfig.accountId=${{ secrets.PREFECT_CLOUD_ACCOUNT_ID }} --set=agent.cloudApiConfig.workspaceId=${{ secrets.PREFECT_CLOUD_WORKSPACE_ID }}" | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| name: Release Helm Chart | ||
|
|
||
| "on": | ||
| push: | ||
| tags: | ||
| # 2023.9.1, but not 2023.09.01 | ||
|
|
@@ -41,8 +41,6 @@ jobs: | |
|
|
||
| - name: Set up Helm | ||
| uses: azure/[email protected] | ||
|
Comment on lines
-44
to
-45
There was a problem hiding this comment. this is the only thing im concerned about - should we just default to the latest (stable) helm version here? There was a problem hiding this comment. Yes I think latest helm3 version |
||
|
|
||
| - name: Prepare GPG key for signing | ||
| run: | | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,12 @@ | ||
| name: Lint and Test Prefect Server Chart | ||
|
|
||
| "on": | ||
| pull_request: | ||
| paths: | ||
| - .github/workflows/server-lint-and-test.yaml | ||
| - .github/linters/server-ct.yaml | ||
| - charts/prefect-server/** | ||
|
|
||
| jobs: | ||
| lint-test: | ||
| name: "lint-test (${{ matrix.kubernetes }})" | ||
|
|
@@ -16,21 +18,24 @@ jobs: | |
| - "1.26.3" | ||
| - "1.27.0" | ||
| fail-fast: false | ||
|
|
||
| steps: | ||
| - name: Checkout Code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Set up Helm | ||
| uses: azure/[email protected] | ||
|
|
||
| - name: Set up chart-testing | ||
| uses: helm/[email protected] | ||
|
|
||
| - name: Run chart-testing (lint) | ||
| run: ct lint --config .github/linters/server-ct.yaml | ||
|
|
||
| - name: Create kind cluster | ||
| uses: helm/[email protected] | ||
| with: | ||
| node_image: "kindest/node:v${{ matrix.kubernetes }}" | ||
|
|
||
| - name: Run chart-testing (install) | ||
| run: ct install --config .github/linters/server-ct.yaml --helm-extra-set-args "--set=postgresql.auth.password=TESTING" | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these were managing the version of helm/kind to specify in the lint/test workflows. Since we were always updating to latest, removing this and just allowing the default version to apply.