feat: add extraArgs to deployment's args field #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to add extra arguments to all three deployments. This allows to specify extra arguments that are not possible with the (current) chart.
Our use case is to specify the path to the base job template of a worker. We do not want to specify it via values.yaml (and configmap) as the template has already been added to our custom worker image. We would like to keep this workflow, hence we need an option to specify extra arguments to the worker pod/container.
I've also included some semantic fixes to the values schema of the worker which mentioned "server" instead of "worker" in some cases.
I've tested the charts and it works as expected. I deliberatly did not specify the type of the items in the list, as we cast them to strings anyway in the deployment.yaml