Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): mounted fs path for static-ui-dir #289

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

parkedwards
Copy link
Contributor

@parkedwards parkedwards commented Jan 19, 2024

resolves #288

image

$ kl prefect-server-5dd4b5755-7b5k7

 ___ ___ ___ ___ ___ ___ _____
| _ \ _ \ __| __| __/ __|_   _|
|  _/   / _|| _|| _| (__  | |
|_| |_|_\___|_| |___\___| |_|

Configure Prefect to communicate with the server with:

    prefect config set PREFECT_API_URL=http://0.0.0.0:4200/api

View the API reference documentation at http://0.0.0.0:4200/docs

Check out the dashboard at http://0.0.0.0:4200

@parkedwards parkedwards requested a review from a team as a code owner January 19, 2024 21:31
@@ -54,6 +54,8 @@ server:
prefectUiApiUrl: ""
# -- sets PREFECT_UI_URL
prefectUiUrl: ""
# -- sets PREFECT_UI_STATIC_DIRECTORY
prefectUiStaticDirectory: "/ui_build"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a default value, or else the server container will look for a non-existent default that is baked into the application code. so the expectation is, when using the helm chart, we will be setting this by either user-provided value or this default value

Copy link
Contributor

@jimid27 jimid27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@@ -141,6 +143,9 @@ spec:
- mountPath: /tmp
name: scratch
subPathExpr: tmp
- mountPath: {{ .Values.server.uiConfig.prefectUiStaticDirectory }}
name: scratch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing really special about this directory, so we can re-use the emptyDir that we initialize here

@parkedwards parkedwards merged commit 5193835 into main Jan 19, 2024
3 checks passed
@parkedwards parkedwards deleted the fix/empty-ui-static-dir branch January 19, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PREFECT_UI_STATIC_DIRECTORY and emptyDir volume mount to fix Permission Error
3 participants