Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): mounted fs path for static-ui-dir #289

Merged
merged 1 commit into from
Jan 19, 2024
Merged

fix(server): mounted fs path for static-ui-dir #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions charts/prefect-server/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ spec:
- name: PREFECT_UI_URL
value: {{ .Values.server.uiConfig.prefectUiUrl | quote }}
{{- end }}
- name: PREFECT_UI_STATIC_DIRECTORY
value: {{ .Values.server.uiConfig.prefectUiStaticDirectory | quote }}
{{- if .Values.postgresql.enabled }}
- name: PREFECT_API_DATABASE_CONNECTION_URL
valueFrom:
Expand Down Expand Up @@ -141,6 +143,9 @@ spec:
- mountPath: /tmp
name: scratch
subPathExpr: tmp
- mountPath: {{ .Values.server.uiConfig.prefectUiStaticDirectory }}
name: scratch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing really special about this directory, so we can re-use the emptyDir that we initialize here

subPathExpr: ui-build
{{- if .Values.server.extraVolumeMounts }}
{{- include "common.tplvalues.render" (dict "value" .Values.server.extraVolumeMounts "context" $) | nindent 12 }}
{{- end }}
Expand Down
2 changes: 2 additions & 0 deletions charts/prefect-server/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ server:
prefectUiApiUrl: ""
# -- sets PREFECT_UI_URL
prefectUiUrl: ""
# -- sets PREFECT_UI_STATIC_DIRECTORY
prefectUiStaticDirectory: "/ui_build"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs a default value, or else the server container will look for a non-existent default that is baked into the application code. so the expectation is, when using the helm chart, we will be setting this by either user-provided value or this default value


# see here for a full list of possible environment variables - https://docs.prefect.io/latest/api-ref/prefect/settings/
# -- array with environment variables to add to server nodes
Expand Down
Loading