Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notify job #14758

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Remove notify job #14758

merged 1 commit into from
Jul 25, 2024

Conversation

cicdw
Copy link
Member

@cicdw cicdw commented Jul 25, 2024

This job posted to an internal slack channel whenever tests were failing on main regularly; I'll be monitoring test failures closely on a daily basis and so this isn't needed anymore, and I want to keep the repo as tidy as possible.

@cicdw cicdw added the development Tech debt, refactors, CI, tests, and other related work. label Jul 25, 2024
@cicdw cicdw requested a review from chrisguidry July 25, 2024 17:12
Copy link

codspeed-hq bot commented Jul 25, 2024

CodSpeed Performance Report

Merging #14758 will improve performances by 16.91%

Comparing remove-notify-job (5f57fe3) with main (a8f40b0)

Summary

⚡ 1 improvements
✅ 4 untouched benchmarks

Benchmarks breakdown

Benchmark main remove-notify-job Change
bench_flow_call[options1] 281.8 ms 241.1 ms +16.91%

@cicdw cicdw merged commit a5563e6 into main Jul 25, 2024
24 checks passed
@cicdw cicdw deleted the remove-notify-job branch July 25, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Tech debt, refactors, CI, tests, and other related work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants