Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notify job #14758

Merged
merged 1 commit into from
Jul 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions .github/workflows/python-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -182,43 +182,6 @@ jobs:
&& docker container logs postgres
|| echo "Ignoring bad exit code"

notify-tests-failing-on-main:
needs: run-tests
if: github.ref == 'refs/heads/main' && failure()
runs-on: ubuntu-latest
env:
FAILURE_THRESHOLD: 1
steps:
- name: Download all failure flags
uses: actions/download-artifact@v4
with:
path: failure-flags/

- name: Check for failure flags
id: check_failure
run: |
failure_count=$(ls -1q failure-flags/*/*.txt | wc -l)

if [ $failure_count -gt $FAILURE_THRESHOLD ]; then
too_many_tests_failed="true"
else
too_many_tests_failed="false"
fi
echo "failure_count=$failure_count" >> $GITHUB_OUTPUT
echo "too_many_tests_failed=$too_many_tests_failed" >> $GITHUB_OUTPUT

- name: Send Slack Notification
if: ${{ steps.check_failure.outputs.too_many_tests_failed == 'true' }}
uses: 8398a7/action-slack@v3
with:
author_name: Prefect OSS Tests Failing on Main
channel: CBH18KG8G # This is #engineering
fields: message,commit,author,workflowRun
status: failure
text: ":warning: Unit tests are failing in Prefect's main branch. Commit author: please either fix or remove the failing tests. If you remove the failing tests create a GitHub issue with the details."
env:
SLACK_WEBHOOK_URL: ${{ secrets.ENGINEERING_REVIEW_SLACK_WEBHOOK_URL }}

run-docker-tests:
runs-on:
group: oss-larger-runners
Expand Down
Loading