We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This tool is doing amazing things but it can be improved. For example code complexity of class https://github.com/PrestaShop/prestashop-shop-creator/blob/master/src/Generator/EntityGenerator.php is high.
First thing needed to enable refactoring of this repository would be to add automated tests, and run them in a CI using GitHub Actions.
When this is done we will be able to use CI to detect whether our refactoring is breaking an existing feature / behavior or not.
I suppose that we can use this opportunity to add the standard CI helpers: phpstan, php-cs-fixer... see for example https://github.com/PrestaShop/ps_linklist/blob/dev/.github/workflows/php.yml
The text was updated successfully, but these errors were encountered:
Maybe we can add some steps on this issue with several PR associated :
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
This tool is doing amazing things but it can be improved. For example code complexity of class https://github.com/PrestaShop/prestashop-shop-creator/blob/master/src/Generator/EntityGenerator.php is high.
First thing needed to enable refactoring of this repository would be to add automated tests, and run them in a CI using GitHub Actions.
When this is done we will be able to use CI to detect whether our refactoring is breaking an existing feature / behavior or not.
I suppose that we can use this opportunity to add the standard CI helpers: phpstan, php-cs-fixer... see for example https://github.com/PrestaShop/ps_linklist/blob/dev/.github/workflows/php.yml
The text was updated successfully, but these errors were encountered: