Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve this repository, add tests #23

Open
matks opened this issue Oct 27, 2022 · 1 comment · Fixed by #25, #26 or #27
Open

Improve this repository, add tests #23

matks opened this issue Oct 27, 2022 · 1 comment · Fixed by #25, #26 or #27

Comments

@matks
Copy link
Contributor

matks commented Oct 27, 2022

This tool is doing amazing things but it can be improved. For example code complexity of class https://github.com/PrestaShop/prestashop-shop-creator/blob/master/src/Generator/EntityGenerator.php is high.

First thing needed to enable refactoring of this repository would be to add automated tests, and run them in a CI using GitHub Actions.

When this is done we will be able to use CI to detect whether our refactoring is breaking an existing feature / behavior or not.

I suppose that we can use this opportunity to add the standard CI helpers: phpstan, php-cs-fixer... see for example https://github.com/PrestaShop/ps_linklist/blob/dev/.github/workflows/php.yml

@mflasquin
Copy link
Contributor

mflasquin commented Nov 2, 2022

Maybe we can add some steps on this issue with several PR associated :

  • Add PHP Linter
  • Add php-cs-fixer (with fixes)
  • Add phpstan (with fixes)
  • Add unit tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment