Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve shop creator with phpstan #26

Merged
merged 1 commit into from
Nov 9, 2022
Merged

Improve shop creator with phpstan #26

merged 1 commit into from
Nov 9, 2022

Conversation

mflasquin
Copy link
Contributor

@mflasquin mflasquin commented Nov 3, 2022 •
edited
Loading

Questions Answers
Description? Improve shop creator with phpstan
Type? improvement
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #23
How to test? see mflasquin#4
Possible impacts? Please indicate what parts of the software we need to check to make sure everything is alright.

@mflasquin
Copy link
Contributor Author

POC CI : mflasquin#4

nicosomb
nicosomb reviewed Nov 4, 2022
View reviewed changes
.github/workflows/php.yml Outdated Show resolved Hide resolved
@mflasquin mflasquin force-pushed the improve/23-phpstan branch 2 times, most recently from bb0dbbe to 30197d5 Compare November 4, 2022 08:09
nicosomb
nicosomb previously approved these changes Nov 4, 2022
View reviewed changes
matks
matks requested changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@matks matks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is ok but needs to be rebased to fix git conflicts

Please rebase and ping me and then I will approve ;)

@mflasquin
Copy link
Contributor Author

PR is ok but needs to be rebased to fix git conflicts

Please rebase and ping me and then I will approve ;)

Hi @matks, done 😄

@matks
Copy link
Contributor

matks commented Nov 9, 2022

Thank you @mflasquin

@matks matks merged commit 3e9a62c into PrestaShop:master Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lartist lartist lartist left review comments

@matks matks matks approved these changes

@nicosomb nicosomb nicosomb left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve this repository, add tests
4 participants
@mflasquin @matks @nicosomb @lartist