Improve shop creator with phpstan

.github/workflows/php.yml

@@ -6,11 +6,12 @@ jobs:
     name: PHP Syntax check 7.2 => 8.1
     runs-on: ubuntu-latest
     steps:
-        - name: Cancel Previous Runs
+      - name: Cancel Previous Runs
         uses: styfle/[email protected]
         with:
           all_but_latest: true
           access_token: ${{ github.token }}
+
       - name: Checkout
         uses: actions/[email protected]
 
@@ -28,3 +29,48 @@ jobs:
 
       - name: PHP syntax checker 8.1
         uses: prestashop/github-action-php-lint/8.1@master
+
+  phpstan:
+    permissions:
+      actions: write  # for styfle/cancel-workflow-action to cancel/stop running workflows
+      contents: read  # for actions/checkout to fetch code
+    name: PHP Static Analysis
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        php: [ '7.2', '7.3', '7.4', '8.0', '8.1' ]
+      fail-fast: false
+    steps:
+      - name: Cancel Previous Runs
+        uses: styfle/[email protected]
+        with:
+          all_but_latest: true
+          access_token: ${{ github.token }}
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '7.4'
+          extensions: mbstring, intl, gd, xml, dom, json, fileinfo, curl, zip, iconv, simplexml
+
+      - uses: actions/checkout@v2
+
+      - name: Get Composer Cache Directory
+        id: composer-cache
+        run: echo "::set-output name=dir::$(composer config cache-files-dir)"
+
+      - name: Cache Composer Directory
+        uses: actions/cache@v2
+        with:
+          path: ${{ steps.composer-cache.outputs.dir }}
+          key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
+          restore-keys: ${{ runner.os }}-composer-
+
+      - name: Composer Install
+        run: |
+          composer install --ansi --prefer-dist --no-interaction --no-progress
+          rm composer.lock
+          composer config platform.php ${{ matrix.php }}
+
+      - name: Run phpstan
+        run: ./vendor/bin/phpstan analyse

composer.json

@@ -14,7 +14,8 @@
     "cweagans/composer-patches": "^1.7"
   },
   "require-dev": {
-    "phpunit/phpunit": "~5.2"
+    "phpunit/phpunit": "~5.2",
+    "phpstan/phpstan": "^1.9"
   },
   "autoload": {
     "psr-4": {

phpstan.neon.dist

@@ -0,0 +1,7 @@
+parameters:
+  paths:
+    - app
+    - src
+  level: 5
+  parallel:
+    maximumNumberOfProcesses: 1

src/Generator/EntityGenerator.php

@@ -730,7 +730,7 @@ private function getRelationFromDependencies($relationName, $entityName)
      *
      * @param string $relationName
      *
-     * @return \SimpleXMLElement
+     * @return \SimpleXMLElement|null
      */
     private function getRelationWithMatchingFieldsFromDependencies($relationName)
     {
@@ -795,7 +795,7 @@ private function getRelationWithMatchingFieldsFromDependencies($relationName)
      * @param array $relations
      * @param array $relationFieldValue
      *
-     * @return null
+     * @return \SimpleXMLElement|null
      */
     private function getMatchingRelation(&$relations, $relationFieldValue)
     {

src/Service/XMLGeneratorService.php

@@ -124,7 +124,7 @@ private static function generateXML(
      */
     private static function sortModelWithDependencies(Finder $finder)
     {
-        $dependencies = $storedDependencies = [];
+        $dependencies = $storedDependencies = $parentEntities = [];
 
         foreach ($finder as $file) {
             $pathName = $file->getPathname();