Ask feedback to author of community PRs #93
Conversation
atomiix
commented
Jun 26, 2020
•
atomiix
commented
| Questions | Answers |
|---|---|
| Description? | This new feature will add a comment with a link to a survey once a PR from the community has been merged to get the author's feedback. It will happen once per month max. |
| Type? | new feature |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed ticket? | Partialy Fixes PrestaShop/prestashop-retro#67 |
| How to test? | Tests should passes |
| @@ -58,7 +71,7 @@ public function checkForTableDescription(PullRequest $pullRequest) | |||
| $bodyParser = new BodyParser($pullRequest->getBody()); | |||
|
|
|||
| $validationErrors = $this->validator->validate($bodyParser); | |||
| if (count($validationErrors) > 0) { | |||
| if (\count($validationErrors) > 0) { | |||
There was a problem hiding this comment.
Move to use use function count
There was a problem hiding this comment.
php-cs-fixer won't accept it I already tried ;) Do you think I should change the rule though?
There was a problem hiding this comment.
Ping @PrestaShop/prestashop-core-developers
There was a problem hiding this comment.
What is the reason of adding the backslash here? 🤔
There was a problem hiding this comment.
To make php-cs-fixer happy, that's one of its rules
|
@atomiix what is the status of this PR ? still valid ? or stale ? |
|
@matks still valid! |
atomiix
force-pushed
the
ask-feedback
branch
3 times, most recently
from
dd9c5d4
to
05152a2
Compare
And review too ;) |
|
Hi @atomiix, is there some work left to do before merging this PR? |
atomiix
force-pushed
the
ask-feedback
branch
from
31aa556
to
e18607b
Compare
|
@LouiseBonnard I had to rebase it. Now waiting for reviews ;) |
atomiix
force-pushed
the
ask-feedback
branch
from
e18607b
to
6fe2d8d
Compare
| $since = (new DateTime())->sub(DateInterval::createFromDateString('30 days')); | ||
| } | ||
| $query = 'repo:'.$this->repositoryOwner.'/'.$this->repositoryName.' is:pr is:merged author:'.$mergedFrom.' commenter:'.$commentedBy.' merged:>='.$since->format('Y-m-d'); | ||
| $search = '{ |
There was a problem hiding this comment.
This kind of string should be store in a file 🤔
(Can be done in a new PR)
|
@atomiix Need a rebase |
|
thanx @atomiix ! |
