Change min compatibility & module version #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tleon
commented
Apr 17, 2024
•
tleon
commented
| Questions | Answers |
|---|---|
| Description? | Since 6.0.3 introduced a big change regarding some symfony services, we decided to up the min version and release a 7.0.0 to avoid problems with the 1.7.7.x compatibility. |
| Type? | improvement |
| BC breaks? | no |
| Deprecations? | yes |
| Issue | #35886 |
| How to test? | upgrade the module on 1.7.8.x and upward is ok. |
kpodemski
approved these changes
Apr 17, 2024
|
@tleon 1.7.7 need to be removed in https://github.com/PrestaShop/productcomments/blob/dev/.github/workflows/php.yml |
I think I did already didn't I ? |
|
@tleon Sorry, I checked the current file ;) |
leemyongpakva
approved these changes
Apr 17, 2024
matthieu-rolland
approved these changes
Apr 17, 2024
|
@PrestaShop/qa-functional I'm not sure if it needs any functional tests :) Let us know |
jolelievre
approved these changes
Apr 17, 2024
|
@kpodemski indeed, this doesn't need manual testing as it's just version changes ^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.