Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change min compatibility & module version #204

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Change min compatibility & module version #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45a69c
Change min compatibility version of PS to 1.7.8
tleon Apr 16, 2024
b6e288c
Change module version to 7.0.0
tleon Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/php.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
presta-versions: ['1.7.7', '1.7.8', '8.0', 'latest']
presta-versions: ['1.7.8', '8.0', 'latest']
steps:
- name: Setup PHP
uses: shivammathur/setup-php@v2
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Allow users to post reviews on your products and/or rate them based on specific

## Compatibility

PrestaShop: `1.7.7` or newer
PrestaShop: `1.7.8` or newer

## Multistore compatibility

Expand Down
2 changes: 1 addition & 1 deletion config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<module>
<name>productcomments</name>
<displayName><![CDATA[Product Comments]]></displayName>
<version><![CDATA[6.0.3]]></version>
<version><![CDATA[7.0.0]]></version>
<description><![CDATA[Allows users to post reviews and rate products on specific criteria.]]></description>
<author><![CDATA[PrestaShop]]></author>
<tab><![CDATA[front_office_features]]></tab>
Expand Down
4 changes: 2 additions & 2 deletions productcomments.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ public function __construct()
{
$this->name = 'productcomments';
$this->tab = 'front_office_features';
$this->version = '6.0.3';
$this->version = '7.0.0';
$this->author = 'PrestaShop';
$this->need_instance = 0;
$this->bootstrap = true;
Expand All @@ -60,7 +60,7 @@ public function __construct()
$this->langId = $this->context->language->id;
$this->shopId = $this->context->shop->id ? $this->context->shop->id : Configuration::get('PS_SHOP_DEFAULT');

$this->ps_versions_compliancy = ['min' => '1.7.7', 'max' => _PS_VERSION_];
$this->ps_versions_compliancy = ['min' => '1.7.8', 'max' => _PS_VERSION_];
}

public function install($keep = true)
Expand Down
6 changes: 3 additions & 3 deletions src/Entity/ProductCommentCriterion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ class ProductCommentCriterion
/**
* @var array
*
* @deprecated 6.0.3 - use criterionLangs instead
* @deprecated 7.0.0 - use criterionLangs instead
*/
private $names;

Expand Down Expand Up @@ -139,7 +139,7 @@ public function getCriterionName(): string
/**
* @return array
*
* @deprecated 6.0.3 - migrated to Form\ProductCommentCriterionFormDataProvider
* @deprecated 7.0.0 - migrated to Form\ProductCommentCriterionFormDataProvider
*/
public function getNames()
{
Expand All @@ -151,7 +151,7 @@ public function getNames()
*
* @return ProductCommentCriterion
*
* @deprecated 6.0.3
* @deprecated 7.0.0
*/
public function setNames($langNames)
{
Expand Down
6 changes: 3 additions & 3 deletions src/Repository/ProductCommentCriterionRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ public function remove(ProductCommentCriterion $entity, bool $flush = false): vo
}

/**
* @deprecated 6.0.3 - cascade remove by Entity setting instead
* @deprecated 7.0.0 - cascade remove by Entity setting instead
*/
private function deleteLangs($criterion): int
{
Expand Down Expand Up @@ -167,7 +167,7 @@ public function update(ProductCommentCriterion $criterion): int
}

/**
* @deprecated 6.0.3 - migrated to Form\ProductCommentCriterionFormDataHandler
* @deprecated 7.0.0 - migrated to Form\ProductCommentCriterionFormDataHandler
*/
private function updateLangs($criterion): int
{
Expand Down Expand Up @@ -346,7 +346,7 @@ public function getTypes()
/**
* @return ProductCommentCriterion
*
* @deprecated 6.0.3 - use standard find() instead
* @deprecated 7.0.0 - use standard find() instead
*/
public function findRelation($id_criterion)
{
Expand Down
Loading