Adding blast resistance #384
Conversation
Moondarker
force-pushed
the
blast-resistance
branch
from
ce57fb1
to
ff8d5d6
Compare
|
Gotta note, blast resistance = undefined (values added as 0 in latest commit) correspond very well with hardness = 0 in the same block, and there are a lot of such blocks in 1.16 Example: Dark Oak Stairs What I mean is, something has got to be wrong with the way 1.16 data is extracted |
|
A bug in burger ? |
|
Did you write some kind of merge script to only add properties and not lose the ones you don't extract? |
|
Yep, automated it with a node script to merge existing minecraft-data with resistance data gathered using burger + a powershell script to make it for every major version |
|
Burger output is affected by Pokechu22/Burger#23, will see if I can make a quick workaround for now. |
|
This is ready for review, I don't think it can get any better for now. Output of Burger was patched using a list of special cases gathered from 1.16 sources |
|
Ok will check the pr About doc I completely agree and the easiest way to do this is that each new pr improve the doc a bit. So can you add to the "add new version" guide in doc folder what you did here to get blast resistance so the next person can redo the same ? |
|
Yeah, I just need to clean up a little first. Amount of stuff I collected to get correct values is quite big, but it can be compressed substantially |
|
Actually, just running burger-extractor with PrismarineJS/burger-extractor#13 should do However, no matter what I do, I cannot reproduce I can ofc make a mini-guide about merging new data with minecraft-data without re-generating files from scratch, but it's all about chicken or the egg paradox, and in future it will lead to problems in determining where different pieces of data came from (if everyone will be merging data like that) |
|
today mcdata is a big mix of extractor methods in a perfect world there would be a single code base doing the whole extraction from scratch. But we're not in this world, so let's document what we have and progress incrementally ;) |
|
If we, as a species, lose in some aspects to computers - aspect №1 is data processing What I mean is - documentation is good, but we can:
Doing at least one thing of listed above will greatly improve data consistency P.S. I'm not saying that we should get everything from game files, but the most important and massive things: blocks, items, entities and related things (i.e. metadata descriptions) is something that should definitely come from game files |
|
yes what you are saying has been tried by several people burger also has the same purpose this is a big project, but if you feel like it's important, you could try to contribute to one of these efforts. |
|
unless someone decides to spend some serious time on this, we're not going to solve this extractor problem at once so my suggestion is instead to document what needs to be done to run extractors and improve the extractors as we go |
Contains current minecraft-data data merged with burger-extracted blast resistance
Closes #383