-
-
Notifications
You must be signed in to change notification settings - Fork 616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Ini file settings ignored #669
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR title to a consist meaningful message on what is being change.. Thanks!
Arguably, this is the worst way to handle this. The defaults can no longer be rendered by If we're going to move default values elsewhere, we should use |
@sigmavirus24 thanks for the information about |
@ericwb @sigmavirus24 All changes done. |
So rather than relying on |
@sigmavirus24 i don't know any other way to detect if the user have enter the value via cli or not, if default value is set there is no any elegant way to know if there come from the sys.argvs or is the default value. Please let me know how could i do for solve this issue? i'll happy to do it as you prefer |
Be cause the ArgumentParser args was set to a default value, the ini file is ignored always