Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ini file settings ignored #669

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix Ini file settings ignored #669

Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
329e969
Fix issue #595
ehooo Dec 14, 2020
2f50dad
squash! Fix issue #595
ehooo Dec 14, 2020
fdfc1a0
squash! Fix issue #595
ehooo Dec 14, 2020
92a63b8
Fix issue #595
ehooo Dec 21, 2020
0df9adf
Update help
ehooo Dec 22, 2020
a772ea6
Set on args with argparse.SUPPRESS
ehooo Dec 22, 2020
64ec692
Fix output_format access
ehooo Dec 22, 2020
b8b3cbb
FLAKE8
ehooo Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions bandit/cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,13 +146,13 @@ def main():
)
parser.add_argument(
'-a', '--aggregate', dest='agg_type',
action='store', default='file', type=str,
action='store', default=None, type=str,
choices=['file', 'vuln'],
help='aggregate output by vulnerability (default) or by filename'
)
parser.add_argument(
'-n', '--number', dest='context_lines',
action='store', default=3, type=int,
action='store', default=None, type=int,
help='maximum number of code lines to output for each issue'
)
parser.add_argument(
Expand All @@ -178,18 +178,18 @@ def main():
)
parser.add_argument(
'-l', '--level', dest='severity', action='count',
default=1, help='report only issues of a given severity level or '
'higher (-l for LOW, -ll for MEDIUM, -lll for HIGH)'
default=None, help='report only issues of a given severity level or '
'higher (-l for LOW, -ll for MEDIUM, -lll for HIGH)'
)
parser.add_argument(
'-i', '--confidence', dest='confidence', action='count',
default=1, help='report only issues of a given confidence level or '
'higher (-i for LOW, -ii for MEDIUM, -iii for HIGH)'
default=None, help='report only issues of a given confidence level or '
'higher (-i for LOW, -ii for MEDIUM, -iii for HIGH)'
)
output_format = 'screen' if sys.stdout.isatty() else 'txt'
parser.add_argument(
'-f', '--format', dest='output_format', action='store',
default=output_format, help='specify output format',
default=None, help='specify output format',
choices=sorted(extension_mgr.formatter_names)
)
parser.add_argument(
Expand Down Expand Up @@ -223,7 +223,7 @@ def main():
)
parser.add_argument(
'-x', '--exclude', dest='excluded_paths', action='store',
default=','.join(constants.EXCLUDE),
default=None,
help='comma-separated list of paths (glob patterns '
'supported) to exclude from scan '
'(note that these are in addition to the excluded '
Expand Down Expand Up @@ -404,6 +404,19 @@ def main():
ini_options.get('baseline'),
'path of a baseline report')

if args.agg_type is None:
args.agg_type = 'file'
if args.context_lines is None:
args.context_lines = 3
if args.confidence is None:
args.confidence = 1
if args.severity is None:
args.severity = 1
if args.output_format is None:
args.output_format = output_format
if args.excluded_paths is None:
args.excluded_paths = ','.join(constants.EXCLUDE)

if not args.targets:
LOG.error("No targets found in CLI or ini files, exiting.")
sys.exit(2)
Expand Down