-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Add support for MaxPool unit8 type" #3057
Conversation
This build is OK for merge ✅ |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
auto op = migraphx::op::pooling{ | ||
migraphx::op::pooling_mode::max, {1, 1, 1}, {3, 3, 3}, {3, 3, 3}, {1, 1, 1}, true}; | ||
mm->add_instruction(op, input); | ||
return p; | ||
} | ||
}; | ||
|
||
template struct test_max_pooling_ceil_3d<migraphx::shape::float_type>; | ||
template struct test_max_pooling_ceil_3d<migraphx::shape::uint8_type>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can just comment out uint8_type
test here instead of reverting entire PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@umangyadav As far as I can see on our local setup, by adding -fno-sanitize=float-cast-overflow to
Lines 166 to 170 in ee68f72
stage('Clang ASAN') { | |
def sanitizers = "undefined,address" | |
def debug_flags = "-g -O2 -fno-omit-frame-pointer -fsanitize=${sanitizers} -fno-sanitize-recover=${sanitizers}" | |
def gpu_targets = getgputargets() | |
cmake_build(flags: "-DCMAKE_BUILD_TYPE=debug -DMIGRAPHX_ENABLE_PYTHON=Off -DMIGRAPHX_ENABLE_GPU=Off -DMIGRAPHX_ENABLE_CPU=On -DCMAKE_CXX_FLAGS_DEBUG='${debug_flags}' -DCMAKE_C_FLAGS_DEBUG='${debug_flags}' -DGPU_TARGETS='${gpu_targets}'") |
7b4d9fa
to
a3dd2ba
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3057 +/- ##
========================================
Coverage 91.78% 91.78%
========================================
Files 485 485
Lines 18856 18863 +7
========================================
+ Hits 17307 17314 +7
Misses 1549 1549 ☔ View full report in Codecov by Sentry. |
Reverts #2973
Need to resolve Clang ASAN failure in CI