Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for MaxPool unit8 type" #3057

Merged
merged 2 commits into from
May 9, 2024
Merged

Revert "Add support for MaxPool unit8 type" #3057

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3dd2ba
hold off on test untill fixed
May 9, 2024
9aa24ba
format
May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/verify/test_max_pooling_ceil_3d.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,4 +43,5 @@ struct test_max_pooling_ceil_3d : verify_program<test_max_pooling_ceil_3d<T>>
};

template struct test_max_pooling_ceil_3d<migraphx::shape::float_type>;
template struct test_max_pooling_ceil_3d<migraphx::shape::uint8_type>;
Copy link
Member

@umangyadav umangyadav May 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just comment out uint8_type test here instead of reverting entire PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@umangyadav As far as I can see on our local setup, by adding -fno-sanitize=float-cast-overflow to

AMDMIGraphX/Jenkinsfile

Lines 166 to 170 in ee68f72

stage('Clang ASAN') {
def sanitizers = "undefined,address"
def debug_flags = "-g -O2 -fno-omit-frame-pointer -fsanitize=${sanitizers} -fno-sanitize-recover=${sanitizers}"
def gpu_targets = getgputargets()
cmake_build(flags: "-DCMAKE_BUILD_TYPE=debug -DMIGRAPHX_ENABLE_PYTHON=Off -DMIGRAPHX_ENABLE_GPU=Off -DMIGRAPHX_ENABLE_CPU=On -DCMAKE_CXX_FLAGS_DEBUG='${debug_flags}' -DCMAKE_C_FLAGS_DEBUG='${debug_flags}' -DGPU_TARGETS='${gpu_targets}'")
, these kind of errors should be resolved.

// TODO: uncomment once "Clang ASAN" CI is fixed. See PR 2973 for details
// template struct test_max_pooling_ceil_3d<migraphx::shape::uint8_type>;
Loading