Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIGraphx private lib changes #3108

Merged
merged 3 commits into from
May 23, 2024
Merged

MIGraphx private lib changes #3108

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37097a3
private lib changes
ahsan-ca May 21, 2024
3b45349
Update rocm-cmake hash
ahsan-ca May 22, 2024
fa2e215
Merge branch 'develop' into migraphx-private-libs
pfultz2 May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,5 @@ facebook/[email protected] -X subdir -DCMAKE_DIR=build/cmake
[email protected] -DENABLE_TESTING=OFF
pcre,pfultz2/[email protected] -H sha256:d6f7182602a775a7d500a0cedca6449af0400c6493951513046d17615ed0bf11
danmar/cppcheck@bb2711c22a0be09efe7f1a8da3030876471026c8 -DHAVE_RULES=1 # 2.11
RadeonOpenCompute/rocm-cmake@5a34e72d9f113eb5d028e740c2def1f944619595 --build
RadeonOpenCompute/rocm-cmake@714b1633c635e2915c3bd9352c5cb54a6a7c5a65 --build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the commit hash to the one off of develop.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

-f requirements.txt
1 change: 1 addition & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ register_op(migraphx HEADER migraphx/builtin.hpp OPERATORS builtin::literal buil
rocm_clang_tidy_check(migraphx)
migraphx_generate_export_header(migraphx)
rocm_install_targets(
PRIVATE
TARGETS migraphx
INCLUDE
${CMAKE_CURRENT_SOURCE_DIR}/include
Expand Down
1 change: 1 addition & 0 deletions src/targets/cpu/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ else()
endif()

rocm_install_targets(
PRIVATE
TARGETS migraphx_cpu
INCLUDE
${CMAKE_CURRENT_SOURCE_DIR}/include
Expand Down
1 change: 1 addition & 0 deletions src/targets/fpga/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ rocm_clang_tidy_check(migraphx_fpga)
target_link_libraries(migraphx_fpga migraphx)

rocm_install_targets(
PRIVATE
TARGETS migraphx_fpga
INCLUDE
${CMAKE_CURRENT_SOURCE_DIR}/include
Expand Down
1 change: 1 addition & 0 deletions src/targets/gpu/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ add_subdirectory(driver)
add_subdirectory(hiprtc)

rocm_install_targets(
PRIVATE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GPU lib has binaries for hiprtc-driver and also for gpu-driver i guess. I think they would need to be marked as private as well.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea for hiprtc-driver, it could be marked as PRIVATE, but we can update that in a later PR as we would need to update how we search for the binary as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahsan-ca is there an open issue for moving hiprtc-driver and gpu-driver ? if not can you open one and work on it as next part ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I will open up an issue for this.

TARGETS migraphx_gpu migraphx_device compile_for_gpu
INCLUDE
${CMAKE_CURRENT_SOURCE_DIR}/include
Expand Down
1 change: 1 addition & 0 deletions src/targets/ref/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ target_link_libraries(migraphx_ref PUBLIC migraphx)
migraphx_generate_export_header(migraphx_ref)

rocm_install_targets(
PRIVATE
TARGETS migraphx_ref
INCLUDE
${CMAKE_CURRENT_SOURCE_DIR}/include
Expand Down
1 change: 1 addition & 0 deletions src/tf/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ endif()
target_link_libraries(migraphx_tf PUBLIC migraphx)

rocm_install_targets(
PRIVATE
TARGETS migraphx_tf
)

Loading