MIGraphx private lib changes

[ahsan-ca]

This PR makes changes to MIGraphX to for private libs.

[umangyadav]

GPU lib has binaries for hiprtc-driver and also for gpu-driver i guess. I think they would need to be marked as private as well.

[pfultz2]

Yea for hiprtc-driver, it could be marked as PRIVATE, but we can update that in a later PR as we would need to update how we search for the binary as well.

[umangyadav]

@ahsan-ca is there an open issue for moving hiprtc-driver and gpu-driver ? if not can you open one and work on it as next part ?

[ahsan-ca]

Sure, I will open up an issue for this.

[migraphx-bot]

Test	Batch	Rate new fa2e21	Rate old fea6dd	Diff	Compare
torchvision-resnet50	64	2,778.66	2,790.08	-0.41%	✅
torchvision-resnet50_fp16	64	6,129.27	6,201.67	-1.17%	✅
torchvision-densenet121	32	2,069.75	2,080.81	-0.53%	✅
torchvision-densenet121_fp16	32	3,600.38	3,604.17	-0.11%	✅
torchvision-inceptionv3	32	1,576.56	1,597.80	-1.33%	✅
torchvision-inceptionv3_fp16	32	2,560.16	2,555.75	0.17%	✅
cadene-inceptionv4	16	709.60	716.59	-0.97%	✅
cadene-resnext64x4	16	677.21	677.89	-0.10%	✅
slim-mobilenet	64	5,798.78	5,814.80	-0.28%	✅
slim-nasnetalarge	64	153.94	154.28	-0.22%	✅
slim-resnet50v2	64	1,791.12	2,576.45	-30.48%	🔴
bert-mrpc-onnx	8	958.81	969.14	-1.07%	✅
bert-mrpc-tf	1	373.90	397.87	-6.02%	🔴
pytorch-examples-wlang-gru	1	339.24	448.02	-24.28%	🔴
pytorch-examples-wlang-lstm	1	373.73	372.88	0.23%	✅
torchvision-resnet50_1	1	592.30	605.77	-2.22%	✅
cadene-dpn92_1	1	383.98	386.93	-0.76%	✅
cadene-resnext101_1	1	322.31	324.65	-0.72%	✅
onnx-taau-downsample	1	306.25	307.40	-0.38%	✅
dlrm-criteoterabyte	1	28.23	28.47	-0.83%	✅
dlrm-criteoterabyte_fp16	1	46.85	47.17	-0.66%	✅
agentmodel	1	7,484.64	7,597.51	-1.49%	✅
unet_fp16	2	56.53	56.51	0.04%	✅
resnet50v1_fp16	1	880.55	878.70	0.21%	✅
resnet50v1_int8	1	785.72	785.68	0.00%	✅
bert_base_cased_fp16	64	1,020.95	1,021.06	-0.01%	✅
bert_large_uncased_fp16	32	299.07	298.91	0.05%	✅
bert_large_fp16	1	156.21	156.11	0.06%	✅
distilgpt2_fp16	16	1,830.76	1,831.02	-0.01%	✅
yolov5s	1	473.39	476.11	-0.57%	✅
tinyllama	1	33.00	33.01	-0.04%	✅
vicuna-fastchat	1	160.28	160.53	-0.16%	✅
whisper-tiny-encoder	1	348.83	351.24	-0.69%	✅
whisper-tiny-decoder	1	401.31	397.98	0.84%	✅

This build is not recommended to merge 🔴

[migraphx-bot]

     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (76d1c14) to head (fa2e215).
Report is 156 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3108   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files          486      486           
  Lines        18991    18991           
========================================
  Hits         17438    17438           
  Misses        1553     1553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pfultz2]

Need to update the commit hash to the one off of develop.

[ahsan-ca]

Done.

[ahsan-ca]

I see the following warning for MIGraphX:

-- Enable test package migraphx
-- Found Python: /usr/bin/python3.10 (found suitable version "3.10.12", minimum required is "3") found components: Interpreter 
-- rocm-cmake: Set license file to /code/AMDMIGraphX/AMDMIGraphX/LICENSE.
-- Generate ctest file
-- Configuring done
CMake Warning (dev) at deps/share/rocmcmakebuildtools/cmake/ROCMTest.cmake:230 (install):
  Policy CMP0095 is not set: RPATH entries are properly escaped in the
  intermediary CMake install script.  Run "cmake --help-policy CMP0095" for
  policy details.  Use the cmake_policy command to set the policy and
  suppress this warning.

  RPATH entries for target 'test_verify' will not be escaped in the
  intermediary cmake_install.cmake script.
Call Stack (most recent call first):
  test/verify/CMakeLists.txt:29 (rocm_install_test)
This warning is for project developers.  Use -Wno-dev to suppress it.

-- Generating done
-- Build files have been written to: /code/AMDMIGraphX/AMDMIGraphX/build

I have tried setting cmake_policy in rocm-cmake (inside ROCMInstallTargets.cmake) but still see the warning.