Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove -fopenacc command line option #187

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

mjklemm
Copy link

@mjklemm mjklemm commented Oct 17, 2024

Flang only supports parsing OpenACC, but does not have a code generator for it. Thus, this PR disables the command line options to active OpenACC.

@mjklemm mjklemm self-assigned this Oct 17, 2024
Copy link
Collaborator

@ronlieb ronlieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curiousity: what does the error message look like if user tries to use -fopenacc with this patch active ?

@mjklemm
Copy link
Author

mjklemm commented Oct 17, 2024

It simply says:

flang-new: error: unknown argument: '-fopenacc'

@mjklemm mjklemm merged commit 8902936 into ROCm:amd-trunk-dev Oct 17, 2024
3 of 5 checks passed
ronlieb added a commit that referenced this pull request Oct 29, 2024
dpalermo pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants