Update result.rb #41
Open
Update result.rb #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[This PR](github/scientist#77) of the scientist gem from Oct 2021 changed the interface of the `equivalent_to?` method which no longer transforms an optional block into the `comparator` proc. Instead, one has to pass the comparator directly as a proc. Without that change, the `comparator` variable of `equivalent_to` keeps its default value `nil` which leads to incorrect comparisons, e.g. `Result.equivalent = false` even though `experiment.comparator` returns `true`.
|
Sorry, I left Real Geeks and no longer have commit privileges to this repo. Pinging @larslevie @kevin1024 @LupineDev @Sparkmasterflex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Pass
experiment.comparatorno longer as a block via&experiment.comparatorbut as a proc to thecomparatorargument of theObservation.equivalent_to?method.Why
This PR of the scientist gem from Oct 2021 changed the interface of the
equivalent_to?method which no longer transforms an optional block into thecomparatorproc. Instead, one has to pass the comparator directly as a proc. Without that change, thecomparatorvariable ofequivalent_to?keeps its default valuenilwhich leads to incorrect comparisons, e.g.Result.equivalent = falseeven thoughexperiment.comparatorreturnstrue.Note
We should also increase the minimal required scientist version in the
Gemfile.lockas the interface change is not backward compatible. According to this commit we need at least 1.6.1 but it's 1.6.0 now.