Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update result.rb #41

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update result.rb #41

wants to merge 2 commits into from

Commits on Aug 13, 2022

  1. Update result.rb 

    [This PR](github/scientist#77) of the scientist gem from Oct 2021 changed the interface of the `equivalent_to?` method which no longer transforms an optional block into the `comparator` proc. Instead, one has to pass the comparator directly as a proc. Without that change, the `comparator` variable of `equivalent_to` keeps its default value `nil` which leads to incorrect comparisons, e.g. `Result.equivalent = false` even though `experiment.comparator` returns `true`.
    @s-meinhardt
    s-meinhardt committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    6164f6f View commit details
    Browse the repository at this point in the history

  2. Update result.rb

    @s-meinhardt
    s-meinhardt committed Aug 13, 2022
    Configuration menu
    Copy the full SHA
    be41cb4 View commit details
    Browse the repository at this point in the history