rippling cli: Added flux build init command #7
Conversation
| # TODO: Since run configuration cannot be transferred from import/export settings , it lies inside .idea folder in \ | ||
| # the project directory. This should be a separate command \ | ||
| # https://intellij-support.jetbrains.com/hc/en-us/community/posts/206600965-Export-Import-Run-Configurations | ||
| def create_run_configurations(project_name: str): |
There was a problem hiding this comment.
I thought of initially including this part of command but looks like for pycharm run/debug configuration cannot be transferred so we will have to create .idea folder and copy the xml file inside the folder. I am planning to add this as part of run_server command as I am hoping that app-developer would have opened the project in pycharm. Since adding this file before in this command creates problem with pycharm settings which they pycharm does on project open
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
|
|
||
|
|
||
| def install_pip(): | ||
| subprocess.run([sys.executable, "-m", "ensurepip", "--default-pip"]) |
There was a problem hiding this comment.
[Security]. Detected subprocess function 'run' without a static string.
Developer action:
If this data can be controlled by a malicious actor, it may be an instance of command injection.
Also, don't use shell=True wherever possible. Audit the use of this call to ensure it is not controllable by an external resource.
💬 Reply with /semgrep ignore <reason> or triage in Semgrep Cloud Platform to ignore the finding created by dangerous-subprocess-use.
| from typing import Optional | ||
|
|
||
| import click | ||
| import requests # type: ignore |
There was a problem hiding this comment.
[best-practice]. Untyped 'type: ignore' or specific typed 'type: ignore' comments like 'attr-defined', 'method-assign', 'name-defined', 'operator' should be avoided as they can hide real issues.
💬 Reply with /semgrep ignore <reason> or triage in Semgrep Cloud Platform to ignore the finding created by development_avoid_type_ignore_error.
| @@ -12,3 +13,4 @@ def flux(ctx: click.Context) -> None: | |||
|
|
|||
|
|
|||
| flux.add_command(app) # type: ignore | |||
| flux.add_command(build) # type: ignore | |||
There was a problem hiding this comment.
[best-practice]. Untyped 'type: ignore' or specific typed 'type: ignore' comments like 'attr-defined', 'method-assign', 'name-defined', 'operator' should be avoided as they can hide real issues.
💬 Reply with /semgrep ignore <reason> or triage in Semgrep Cloud Platform to ignore the finding created by development_avoid_type_ignore_error.
JIRA: https://rippling.atlassian.net/browse/APPS-25574
changes: Added flux build init command
Test:
https://www.loom.com/share/02114a47adcd4aeb90ffe8fc46cf1a13